Event Damage Cause for Player Attacks

[TheExtremeBurger]

What this basically does is add the possible melee attack types a player can do to the Event Damage Cause Game Value. The Game Value would be able to output:

player_attack_strong - Attack when a player hits with a fully charged Attack Cooldown
player_attack_weak - Attack when a player hits before the Attack Cooldown is fully charged
player_attack_critical - Attack when a player performs a Critical Hit
player_attack_knockback - Attack when a player performs a Knockback Hit

There could be a few more added here (but could be a bit confusing), which include:

player_shield_block - Attack by a player that gets blocked by a Shield. Would still output if the player disables the shield with the Axe, unless the shield has already been disabled

*Note: the names of the outputs could use "entity" instead of "player" to match the current "entity_sweep_attack"

 

[Frosty]

This sounds cool, but I can't really think of any time it would actually be useful to have. If you could think of one yourself, I would love to hear it!

 

[TheExtremeBurger]

I have a few uses for this, mainly for custom weapons (this led me to making the suggestion lol):
- Testing if a player waited to charge their attack and giving extra damage for that
- Testing if a player used a custom shield to block an attack, instead of checking event damage and if the player was blocking
- Testing if a player did a critical hit rather than checking damage values and fall distance values (would be more accurate)
I mainly wanted these because I wanted to make custom weapons with specific attack treatments lol

 

[AceSugar1799595]

I've always wanted to see something like this in DiamondFire for ages, and would be great if added! But as Frosty said, other than custom weapons, there aren't many other uses of this, and I doubt many players would need to or want to utilize this sort of feature.

 

[Zyborg]

im not sure, but i think shields are like broken in df, and if they cant block hits then this:

player_shield_block - Attack by a player that gets blocked by a Shield. Would still output if the player disables the shield with the Axe, unless the shield has already been disabled

won't work

 

[TheExtremeBurger]

im not sure, but i think shields are like broken in df, and if they cant block hits then this:

won't work

Shields do work, but the duel wielding aspect of DF does not; if an offhand item can do an action the main hand item cannot, in vanilla it will work (for example, holding a sword in your main hand, and blocking with a shield), but in DF, it will just cancel.

 

[Requals]

Shields do work, but the duel wielding aspect of DF does not; if an offhand item can do an action the main hand item cannot, in vanilla it will work (for example, holding a sword in your main hand, and blocking with a shield), but in DF, it will just cancel.

this is being fixed in 5.3.1 (or was)